Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base.Associative is deprecated, use AbstractDict instead. #433

Closed
scls19fr opened this issue Aug 14, 2018 · 5 comments
Closed

Base.Associative is deprecated, use AbstractDict instead. #433

scls19fr opened this issue Aug 14, 2018 · 5 comments
Milestone

Comments

@scls19fr
Copy link
Member

Hello,

With Julia 0.7, Mac OS X, building doc with --depwarn=error flag

10:34 $ julia
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0 (2018-08-08 06:46 UTC)
 _/ |\__'_|_|_|\__'_|  |  Official http://julialang.org/ release
|__/                   |  x86_64-apple-darwin14.5.0

(v0.7) pkg> rm DataStructures
  Updating `~/.julia/environments/v0.7/Project.toml`
  [864edb3b] - DataStructures v0.11.0+ [`~/.julia/dev/DataStructures`]
  Updating `~/.julia/environments/v0.7/Manifest.toml`
 [no changes]

(v0.7) pkg> rm DataStructures
┌ Warning: `DataStructures` not in project, ignoring
└ @ Pkg.Operations /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/Pkg/src/Operations.jl:1127
[ Info: No changes

(v0.7) pkg> dev DataStructures
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
   Cloning git-repo `https://github.com/JuliaCollections/DataStructures.jl.git`
  Updating git-repo `https://github.com/JuliaCollections/DataStructures.jl.git`
[ Info: Path `/Users/scls/.julia/dev/DataStructures` exists and looks like the correct package, using existing path instead of cloning
 Resolving package versions...
  Updating `~/.julia/environments/v0.7/Project.toml`
  [864edb3b] + DataStructures v0.11.0+ [`~/.julia/dev/DataStructures`]
  Updating `~/.julia/environments/v0.7/Manifest.toml`
 [no changes]

julia> ^C

julia>
✔ ~/.julia/dev/DataStructures [master|✚ 1…5]
10:36 $ git pull
Already up to date.
✔ ~/.julia/dev/DataStructures [master|✚ 1…5]
10:36 $
✔ ~/.julia/dev/DataStructures [master|✚ 1…5]
10:36 $ julia --depwarn=error docs/make.jl
Documenter: setting up build directory.
Documenter: expanding markdown templates.
 !! No docs found for 'find(m::SortedDict, k_)'. [src/sorted_containers.md]
 !! No docs found for 'similar(sc::SortedDict)'. [src/sorted_containers.md]
 !! No docs found for 'get(sd::SortedDict,k,v)'. [src/sorted_containers.md]
 !! No docs found for 'get!(sd::SortedDict,k,v)'. [src/sorted_containers.md]
WARNING: importing deprecated binding Base.Associative into DataStructures.
Base.Associative is deprecated, use AbstractDict instead.
ERROR: LoadError: deprecated binding: Base.Associative
Stacktrace:
 [1] top-level scope at none:0
in expression starting at /Users/scls/.julia/dev/DataStructures/docs/make.jl:5

That's odd because I can't see any use of Associative https://github.com/JuliaCollections/DataStructures.jl/search?q=Associative&unscoped_q=Associative

Any idea?

Kind regards

@scls19fr
Copy link
Member Author

This build https://travis-ci.org/JuliaCollections/DataStructures.jl/jobs/415434609#L790 shows also this problem.

@StephenVavasis
Copy link
Contributor

There is mention of Associative in docs/src/sorted_containers.md. Clearly this should be fixed. I already have a pending PR (#426) to make some changes to that file. After that PR is merged, I can make another PR to change Associative to AbstractDict as well. But could an occurrence of Associative inside a string in a doc file cause this error?

@scls19fr
Copy link
Member Author

I don't think a string in a doc file (without macro) can cause that

I think this is
https://github.com/JuliaCollections/DataStructures.jl/blame/6941c2922756d8c5e19e24d23815405daebbbc56/docs/src/sorted_containers.md#L695
which cause that

but we should also change Associative where it makes sense

@scls19fr
Copy link
Member Author

I just changed the Associative to AbstractDict in order to fix #436

However, other mentions of Associative in doc should be changed.

@nickrobinson251 nickrobinson251 added this to the 1.0 milestone Sep 4, 2020
@laborg
Copy link
Collaborator

laborg commented Oct 4, 2023

Those aren't mentioned anymore.

@laborg laborg closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants