Bad rendering of DefaultDict doc

[scls19fr]

Hello,

I shouldn't have merge #431 !
Sorry about that!

With lastest master version of Documenter we are still facing bad rendering

julia> dd = DefaultDict{AbstractString, Vector{Int}}(Vector{Int})
DefaultDict{AbstractString,Array{Int64,1},DataType} with 0 entries

┌ Warning: Deprecated syntax `underscores as an rvalue`.
└ @ none:0

julia> push!(dd["A"], 1)
1-element Array{Int64,1}:
 1

┌ Warning: Deprecated syntax `underscores as an rvalue`.
└ @ none:0

Pinging @fredrikekre @mortenpi from

Kind regards

[scls19fr]

That's just warnings... we can live with that but without warnings, doc looks better

[mortenpi]

FWIW, I can't replicate this (I don't see it in the hosted docs, nor when I build locally).

[fredrikekre]

Start julia with julia --depwarn=error and you will get a tracktrace to the warning.

[scls19fr]

There is still warnings on my local build of doc file:///home/scls/.julia/dev/DataStructures/docs/build/default_dict.html
About hosted doc... problem is #430
About using julia --depwarn=error we first need to tackle #433

[scls19fr]

http://juliacollections.github.io/DataStructures.jl/latest/default_dict.html

We are still seeing

┌ Warning: Deprecated syntax `underscores as an rvalue`.
└ @ none:0

https://github.com/JuliaCollections/DataStructures.jl/tree/gh-pages was updated 2 minutes ago...

So there is still an issue with that

[fredrikekre]

Seems to only happen on Travis then.

[scls19fr]

That's odd because I don't see it now on my local build. But you are right we are still seeing this on Travis!

[fredrikekre]

Can you try changing julia = "0.7" to julia = "1.0" in docs/make.jl?

[mortenpi]

I was now able to get it to replicate on my machine, but only on 0.7.0. Interestingly, depawn = error does not make the build fail and the depwarns disappear.

[fredrikekre]

So just build the docs on 1.0 where deprecations are removed then 😛

[scls19fr]

#430 is reappearing...
https://github.com/JuliaCollections/DataStructures.jl/tree/gh-pages (only updated 2 hours ago)
maybe I should add 1.0 to .travis.yml also (nightly is not enough)

[mortenpi]

So this appears to be a potential bug in Documenter. To work around it, but still deploy on 0.7, you can remove the empty lines in at-repl blocks. The warnings come from those.

[scls19fr]

That's not a big problem for now.
I will keep it like that. Could you open an issue on Documenter.jl
and ping me when you find a fix ?
So we could test that here

[mortenpi]

maybe I should add 1.0 to .travis.yml also (nightly is not enough)

Yes. Also make sure that all your scripts support 1.0.. there is a "Pkg missing" error on the nightly. The Travis logs generally have all the logs that help debugging such problems.

when you find a fix ?

Not 100% this will happen. This might be a weird 0.7-only thing (e.g. some interaction with how deprecations are implemented).

[laborg]

The bug was closed on Documenter.