Allow non-string indices for Trie #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems sensible. |
oxinabox
reviewed
Oct 8, 2021
| node = subtrie(t, key) | ||
| if node != nothing && node.is_key | ||
| return node.value | ||
| end | ||
| return notfound | ||
| end | ||
|
|
||
| function Base.keys(t::Trie, prefix::AbstractString="", found=AbstractString[]) | ||
| _concat(prefix::String, char::Char) = string(prefix, char) | ||
| _concat(prefix::Vector{T}, char::T) where {T} = vcat(prefix, char) |
There was a problem hiding this comment.
Is all we need to add in order to support arbitrary iterators just:
Suggested change
| _concat(prefix::Vector{T}, char::T) where {T} = vcat(prefix, char) | |
| _concat(prefix, char) = Iterators.flatten(prefix, (char,)) |
?
There was a problem hiding this comment.
Do you mean Iterators.flatten((prefix, (char,)))?
That would cause the types to explode:
julia> p1 = [1]
1-element Vector{Int64}:
1
julia> p2 = Iterators.flatten((p1, (2,)))
Base.Iterators.Flatten{Tuple{Vector{Int64}, Tuple{Int64}}}(([1], (2,)))
julia> p3 = Iterators.flatten((p2, (3,)))
Base.Iterators.Flatten{Tuple{Base.Iterators.Flatten{Tuple{Vector{Int64}, Tuple{Int64}}}, Tuple{Int64}}}((Base.Iterators.Flatten{Tuple{Vector{Int64}, Tuple{Int64}}}(([1], (2,))), (3,)))
As _concat only receives objects derived from _empty_prefix, which are either Strings or Vectors, I don't think this needs to be generalized further. Instead, it might be good to wrap the 3-argument keys (Base.keys(t) = _keys(t)), such that arguments 2 and 3 are not accessible to the average user.
oxinabox
approved these changes
Oct 8, 2021
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by dropping the
::AbstractStringrestriction. I considered replacing that by::Union{AbstractString,AbstractVector}(thereby wondering whyAbstractString <: AbstractVectordoesn't hold). Which one would you prefer?This is breaking as the original type parameter (denoting the value type) is now in second position, such that the parameters follow the common key-value pattern like e.g.
Dicthas. I noticed that you are feature-frozen (#479), but I think it would be better to consider changing the order now instead of adding this feature later in a non-breaking manner (i.e. reversing the type parameters).This is ready for comments. If there is anything I can change to improve this PR, I'm happy to do so. 🙂