New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: LazySets.jl: Scalable Symbolic-Numeric Set Computations #97
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @gdalle, @blegat it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/JuliaCon/proceedings-review) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Failed to discover a |
Wordcount for |
|
|
@mforets please note the issues reported by whedon above, namely the missing DOI and the section on a statement of need. This is fine if this doesn't have this name but there should be at least a paragraph in the paper stating it |
when you do some modifications, you can rerun compilation yourself with |
@whedon generate pdf |
The statement of need can be found in paragraph 2 of the Introduction (Section 1). We just made a small change describing who the target audience is. |
@whedon check references |
|
The paper is well written, I would recommend acceptance with minor revision. My comments are the following:
|
@blegat Thanks for the thorough reading! We added JuliaReach/LazySets-JuliaCon21#2 to address the review. Feel free to comment there. |
@whedon generate pdf |
General reviewThis paper introduces a very rich and thoughtfully-crafted package for set representation. The key features of LazySets.jl are clearly stated and illustrated with very visual examples. Its natural syntax, high performance, integration into the Julia ecosystem and extensive documentation are tremendous assets. I recommend acceptance with minor revision. To make the paper even better, the authors could emphasize why the core functionalities of their package (like support function computations) are precisely the ones we need, especially in fields like convex analysis or reachability. A more thorough comparison with competing libraries would also be welcome. Provided these two points are addressed, I will be able to check the remaining boxes in the Context section below. For some reason I am not able to edit the checklist, so I reproduce it below. Reviewer checklistConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
Content
|
I have put more detailed comments in this issue JuliaReach/LazySets-JuliaCon21#4 |
👋 @blegat, please update us on how your review is going (this is an automated reminder). |
👋 @gdalle, please update us on how your review is going (this is an automated reminder). |
no problem, sorry for the automatic whedon reminder |
@whedon set 10.5281/zenodo.5761068 as archive |
OK. 10.5281/zenodo.5761068 is the archive. |
|
@whedon set v1.53.4 as version |
OK. v1.53.4 is the version. |
Also: can you check the missing DOI and add it to the references? |
|
@whedon generate pdf |
@whedon check references |
|
confirmed
Yes, sorry, it's there now! |
@whedon recommend-accept |
|
👋 @JuliaCon/jcon-eics, this paper is ready to be accepted and published. Check final proof 👉 JuliaCon/proceedings-papers#49 If the paper PDF and Crossref deposit XML look good in JuliaCon/proceedings-papers#49, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JCON! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thank you @matbesancon for the editorial work and @gdalle and @blegat for your time reviewing our submission. It was our first experience with an open review process. It went so smoothly! We would highly recommend it to our colleagues. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! JuliaCon Proceedings is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@mforets sorry there is a rendering error: https://proceedings.juliacon.org/papers/10.21105/jcon.00097 |
@matbesancon we just merged JuliaReach/LazySets-JuliaCon21#7 to remove the star. What should we do now? |
Thank you, the rest will be on our side to change the paper :) |
Thanks, and sorry for the extra work. |
Submitting author: @mforets (Marcelo Forets)
Repository: https://github.com/JuliaReach/LazySets-JuliaCon21
Branch with paper.md (empty if default branch):
Version: v1.53.4
Editor:
Reviewers: @gdalle, @blegat
Archive:
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gdalle & @blegat, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @matbesancon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @gdalle
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
paper.tex
file include a list of authors with their affiliations?Content
Review checklist for @blegat
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Paper format
paper.tex
file include a list of authors with their affiliations?Content
The text was updated successfully, but these errors were encountered: