Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the API to make it more reusable #88

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jun 21, 2020

This pull request is a major refactoring of both the public API and the private (internal) API.

Closes #87

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #88    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           14        17     +3     
  Lines          177       311   +134     
==========================================
+ Hits           177       311   +134     
Impacted Files Coverage Δ
src/SimpleContainerGenerator.jl 100.00% <ø> (ø)
src/assert.jl 100.00% <ø> (ø)
src/backups_of_simplecontainergenerator.jl 100.00% <ø> (ø)
src/generate_helper_files.jl 100.00% <ø> (ø)
src/generate_install_packages.jl 100.00% <ø> (ø)
src/generate_packagecompiler_install.jl 100.00% <ø> (ø)
src/generate_packagecompiler_run.jl 100.00% <ø> (ø)
src/generate_precompile_execution.jl 100.00% <ø> (ø)
src/julia.jl 100.00% <ø> (ø)
src/utils.jl 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0675135...4d92ddf. Read the comment docs.

@DilumAluthge DilumAluthge force-pushed the dpa/refactor-api branch 10 times, most recently from 7fb4155 to 6e6455d Compare June 25, 2020 12:26
@DilumAluthge DilumAluthge merged commit 943cf58 into master Aug 30, 2020
@DilumAluthge DilumAluthge deleted the dpa/refactor-api branch August 30, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant