Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback_control causes a stackoverflow on DelayLtiSystem #815

Closed
pepijndevos opened this issue Mar 5, 2023 · 2 comments · Fixed by #816
Closed

feedback_control causes a stackoverflow on DelayLtiSystem #815

pepijndevos opened this issue Mar 5, 2023 · 2 comments · Fixed by #816

Comments

@pepijndevos
Copy link

julia> sys = feedback_control(tf([1], [0.1, 1]), delay(0.1))
ERROR: StackOverflowError:
Stacktrace:
 [1] feedback(sys1::DelayLtiSystem{Float64, Float64}, sys2::DelayLtiSystem{Float64, Float64}; kwargs::Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol}, NamedTuple{(:Z2, :Zperm), Tuple{Colon, Vector{Int64}}}}) (repeats 39992 times)
   @ ControlSystemsBase ~/.julia/packages/ControlSystemsBase/8Sk6N/src/types/Lti.jl:34
@baggepinnen
Copy link
Member

I opened #817 to keep track of making this work. I'd like to solve a more general problem rather than adding a rather complex hack to support this particular instance of the problem, unfortunately, the general problem requires quite a bit of work to implement.

@baggepinnen
Copy link
Member

For now, you can obtain the closed loop systems from r->y and r->u separately using

julia> Gry = feedback(tf([1], [0.1, 1]) * delay(0.1));

julia> Gru = feedback(delay(0.1), tf([1], [0.1, 1]));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants