Introduce recorddelim to CSV.write
#376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can specify the delimeter for terminating records as a new keyword argument `recorddelim`. The default remains `'\n'`.
quinnj
requested changes
Jan 15, 2019
| @@ -154,6 +155,7 @@ end | |||
| # handle unknown schema case | |||
| function write(::Nothing, rows, file::Union{String, IO}; | |||
| delim::Union{Char, String}=',', | |||
| recorddelim::Union{Char, String}='\n', | |||
There was a problem hiding this comment.
I'd rather just call this newline
There was a problem hiding this comment.
Happy to oblige... but technically the record seperator doesn't have to be a line seperator at all.
For example, our literal matrices might have field delimiter ' ' and record delimiter ';' and no newlines.
|
A bit off-topic, but it would be nice to accept both |
quinnj
added a commit
that referenced
this pull request
Apr 29, 2019
* Add `decimal` keyword argument to support custom float printing (fixes #385) * Add additional validation of quote/escape character arguments (fixes #369) * Add `quotestrings` keyword argument to support forcing all strings to be quoted (fixes #362) * Add `newline` keyword argument to support a custom row separator (fixes #375, supersedes #376)
Merged
|
Implemented in #406 |
quinnj
added a commit
that referenced
this pull request
Apr 30, 2019
* CSV.write enhancements * Add `decimal` keyword argument to support custom float printing (fixes #385) * Add additional validation of quote/escape character arguments (fixes #369) * Add `quotestrings` keyword argument to support forcing all strings to be quoted (fixes #362) * Add `newline` keyword argument to support a custom row separator (fixes #375, supersedes #376) * Fix grisu use in 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can specify the delimeter for terminating records as a new keyword argument
recorddelim. The default remains'\n'.Resolves #375.
If the approach seems reasonable I can add tests and docs.