Use isequal() to compare arrays containing nulls #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjprybol
approved these changes
Oct 3, 2017
nalimilan
force-pushed
the
nl/≅
branch
4 times, most recently
from
8c35387
to
5273a38
Compare
The newly introduced promote_rule() breaks with CategoricalValue.
This is needed to work with the next Nulls release, where == will return null in this case.
These are equivalent to the AbstractArray{>:Null} fallback provided by Nulls,
but more efficient when comparing two CategoricalArrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to work with the next Nulls release, where
==will return null in this case.This is only the first part of the changes, the next one will have to introduce
==methods forCategoricalArrayto handle three-valued logic, similar to JuliaData/Missings.jl#37. EDIT: added a second commit.The PR should probably add a requirement on the next Nulls release since the
==methods it introduces wouldn't be consistent with those used bynullin the current version of Nulls. EDIT: done.