Skip to content

Commit

Permalink
Fixes for hashing changes (JuliaLang/julia#6624)
Browse files Browse the repository at this point in the history
  • Loading branch information
simonster committed May 11, 2014
1 parent b555ea8 commit 3cbe03f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/dataframe/dataframe.jl
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ end
function Base.hash(adf::AbstractDataFrame)
h = hash(size(adf)) + 1
for i in 1:size(adf, 2)
h = bitmix(h, int(hash(adf[i])))
h = hash(adf[i], h)
end
return uint(h)
end
Expand Down
1 change: 1 addition & 0 deletions src/other/index.jl
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Base.names(x::Index) = copy(x.names)
Base.copy(x::Index) = Index(copy(x.lookup), copy(x.names))
Base.deepcopy(x::Index) = Index(deepcopy(x.lookup), deepcopy(x.names))
Base.isequal(x::Index, y::Index) = isequal(x.lookup, y.lookup) && isequal(x.names, y.names)
Base.(:(==))(x::Index, y::Index) = isequal(x, y)

function names!(x::Index, nm::Vector{Symbol})
if length(nm) != length(x)
Expand Down

3 comments on commit 3cbe03f

@simonster
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and the changes to DataArrays) fail on Travis because the nightly builds don't seem to have been updated since the hashing changes. cc @staticfloat, although I suspect you already know.

@staticfloat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @simonster! I actually did not know, since my scripts were still running, but there was a failure in uploading to canonical's servers. This has been fixed now, so we should get new nightlies soon.

@simonster
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new nightlies are up and the Travis tests now pass. Thanks!

Please sign in to comment.