Merge pull request #1292 from JuliaData/nl/allowmissing!

Add one-argument version of allowmissing!()
JuliaData · Nov 30, 2017 · 74eb890 · 74eb890
2 parents bbb2503 + 7f6eee1
commit 74eb890
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/dataframe/dataframe.jl b/src/dataframe/dataframe.jl
@@ -726,7 +726,7 @@ function allowmissing!(df::DataFrame, col::ColumnIndex)
     df[col] = Vector{Union{eltype(df[col]), Missing}}(df[col])
     df
 end
-function allowmissing!(df::DataFrame, cols::Vector{T}) where T <: ColumnIndex
+function allowmissing!(df::DataFrame, cols::AbstractVector{<: ColumnIndex}=1:size(df, 2))
     for col in cols
         allowmissing!(df, col)
     end

diff --git a/test/dataframe.jl b/test/dataframe.jl
@@ -438,7 +438,13 @@ module TestDataFrame
         allowmissing!(df, 1)
         @test isa(df[1], Vector{Union{Int, Missing}})
         @test !isa(df[2], Vector{Union{Int, Missing}})
+
+        df = DataFrame(Any[collect(1:10), collect(1:10)])        
         allowmissing!(df, [1,2])
         @test isa(df[1], Vector{Union{Int, Missing}}) && isa(df[2], Vector{Union{Int, Missing}})
+
+        df = DataFrame(Any[collect(1:10), collect(1:10)])        
+        allowmissing!(df)
+        @test isa(df[1], Vector{Union{Int, Missing}}) && isa(df[2], Vector{Union{Int, Missing}})
     end
 end