add comments from the review

JuliaData · Oct 13, 2020 · c707173 · c707173
1 parent 67e9b0a
commit c707173
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/Project.toml b/Project.toml
@@ -44,5 +44,5 @@ Missings = "0.4.2"
 PooledArrays = "0.5"
 Reexport = "0.1, 0.2"
 SortingAlgorithms = "0.1, 0.2, 0.3"
-Tables = "1"
+Tables = "1.1"
 TableTraits = "0.4, 1"
diff --git a/src/dataframe/dataframe.jl b/src/dataframe/dataframe.jl
@@ -17,15 +17,11 @@ DataFrame(pairs::Pair{Symbol,<:Any}...; makeunique::Bool=false, copycols::Bool=t
 DataFrame(pairs::Pair{<:AbstractString,<:Any}...; makeunique::Bool=false,
           copycols::Bool=true)
 DataFrame(pairs::AbstractVector{<:Pair}; makeunique::Bool=false, copycols::Bool=true)
-DataFrame() # an empty DataFrame
-DataFrame(column_eltypes::AbstractVector, names::AbstractVector{Symbol},
-          nrows::Integer=0; makeunique::Bool=false)
-DataFrame(column_eltypes::AbstractVector, names::AbstractVector{<:AbstractString},
-          nrows::Integer=0; makeunique::Bool=false)
 DataFrame(ds::AbstractDict; copycols::Bool=true)
 DataFrame(table; makeunique::Bool=false, copycols::Bool=true)
 DataFrame(::Union{DataFrame, SubDataFrame}; copycols::Bool=true)
 DataFrame(::GroupedDataFrame; keepkeys::Bool=true)
+DataFrame() # an empty DataFrame
 ```
 
 # Arguments