Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allocate(::Type{Null}) #1239

Merged
merged 2 commits into from Sep 21, 2017
Merged

Add allocate(::Type{Null}) #1239

merged 2 commits into from Sep 21, 2017

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Sep 20, 2017

Otherwise allocate(::Type{T}, rows, ref) where {T <: Union{WeakRefString, Null}} method gets called resulting in an error.

@nalimilan
Copy link
Member

Is there a way to test this?

also test DataFrameStream creation
@alyst
Copy link
Contributor Author

alyst commented Sep 20, 2017

Originally I've encountered it while trying to CSV.read() a table with all-nulls columns. It fails in DataFrame(schema) call that should create a DataFrameStream() object.
That's what I've added to the tests. But since this API is new to me, I just don't know whether it's a valid code pattern or the user code triggering this path should look different.

@coveralls
Copy link

coveralls commented Sep 20, 2017

Coverage Status

Coverage increased (+0.3%) to 88.358% when pulling 7307a89 on alyst:allocate_nulls into 75ad2fe on JuliaData:master.

@coveralls
Copy link

coveralls commented Sep 20, 2017

Coverage Status

Coverage increased (+0.3%) to 88.358% when pulling 7307a89 on alyst:allocate_nulls into 75ad2fe on JuliaData:master.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the addition.

@quinnj quinnj merged commit f0422b3 into JuliaData:master Sep 21, 2017
@alyst alyst deleted the allocate_nulls branch September 25, 2017 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants