Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rename API #1269

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Improve rename API #1269

merged 1 commit into from
Oct 28, 2017

Conversation

nalimilan
Copy link
Member

Using pairs is more convenient, more flexible and more consistent.

@nalimilan
Improve rename API
8e1dcb6 
Using pairs is more convenient, more flexible and more consistent.
cjprybol
cjprybol approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@cjprybol cjprybol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 👍 to no longer allowing both rename(!)(::DataFrame, ::Function) and rename(!)(::Function, ::DataFrame) too.

ararslan
ararslan approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 72.88% when pulling 8e1dcb6 on nl/rename into 902e131 on master.

@nalimilan
Copy link
Member Author

It's so nice to have tests passing on 0.7 again...

@nalimilan nalimilan merged commit 30ab24e into master Oct 28, 2017
@nalimilan nalimilan deleted the nl/rename branch October 28, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjprybol cjprybol cjprybol approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nalimilan @coveralls @cjprybol @ararslan