Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include_string call #1271

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Remove include_string call #1271

merged 1 commit into from
Nov 2, 2017

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Nov 2, 2017

This causes endless pain and headache because of JuliaLang/julia#24447

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 72.956% when pulling a21eef2 on jq/removeincludestring into 30ab24e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 72.956% when pulling a21eef2 on jq/removeincludestring into 30ab24e on master.

cjprybol
cjprybol approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@cjprybol cjprybol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jacob!

@quinnj quinnj merged commit 9d0e065 into master Nov 2, 2017
@quinnj quinnj deleted the jq/removeincludestring branch November 2, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjprybol cjprybol cjprybol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quinnj @coveralls @cjprybol