WIP: Port to Missings #1278
Merged
WIP: Port to Missings #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate nullable!() in favor of allow_missing!(). dropnull!() does not need a deprecation since it has been introduced since the last release.
|
Base tends to avoid underscores in names when possible, so perhaps we should consider |
|
WeakRefStrings & DataStreams are now tagged w/ Missing ports |
|
Cool, CI has passed now. |
|
Merge? Due to the ultra-strict rules I enabled, I cannot do it myself... :-) |
andreasnoack
approved these changes
Nov 20, 2017
|
I tried but just realized my review is not worth anything in JuliaData. |
quinnj
approved these changes
Nov 20, 2017
|
That should be fixed now @andreasnoack 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
nullable!()in favor ofallow_missing!().dropnull!()does not need a deprecationsince it has been introduced since the last release.
CI won't pass until DataStreams is ported to Missings.