Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CodecZlib from GZip #1289

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Nov 26, 2017

I'm not sure whether writetable() is already at its end-of-life stage, but if it stays for a while, it might be better to switch to CodecZlib.jl from GZip.jl as the latter is deprecated and not actively maintained.

@coveralls
Copy link

coveralls commented Nov 26, 2017

Coverage Status

Coverage remained the same at 72.926% when pulling 4b7cb02 on alyst:use_codeczlib into bb1e8d6 on JuliaData:master.

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have said it has reached its end of life since it's deprecated, but since the code is ready...

Copy link
Contributor

@cjprybol cjprybol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyst! I agree with @nalimilan here that we probably don't want to fix anything related to readtable and writetable going forward now that they're deprecated, but you already have the PR ready to go so why not take it.

@cjprybol cjprybol merged commit bbb2503 into JuliaData:master Nov 28, 2017
@cjprybol
Copy link
Contributor

Have we set an end-of-life date for read/writetable functions? DataFrames 0.12? Julia 1.0? Maybe each version release (0.11.2, 0.11.3, etc.) we add a sleep(10) call until the delay becomes so unbearable that everyone voluntary converts their code to use CSV.jl?

@nalimilan
Copy link
Member

I don't think we're in a hurry to remove them, they're not a big burden. It would be logical to remove them in the next pseudo-major release, so 0.12 I guess.

@alyst alyst deleted the use_codeczlib branch December 13, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants