add skipmissing to by #1939
Merged
add skipmissing to by #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Sep 3, 2019
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
|
Yeah, this is what happens if I think something is simple :(. |
nalimilan
approved these changes
Sep 4, 2019
|
I have added a documentation of |
nalimilan
approved these changes
Sep 4, 2019
|
Thank you. I will merge this once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
byandgroupbyconsistent.It is marginally breaking as someone in
bycould have wanted to create column namedskipmissing(a similar problem we now have withsort), but I think it is OK to go with it without deprecation period.