Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates required for Julia 1.5 #2223

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented May 4, 2020

Fixes #2221.

Additionaly updates DataFrames.jl to changes in internal implementation of broadcasting in Base.

@bkamins bkamins added this to the 1.0 milestone May 4, 2020
@bkamins bkamins added CI non-breaking The proposed change is not breaking priority labels May 4, 2020
@bkamins
Copy link
Member Author

bkamins commented May 4, 2020

@nalimilan - fortunately the changes required are independent of everything else we change.

@bkamins
Copy link
Member Author

bkamins commented May 4, 2020

@nalimilan - I have made one more update that was failing on 32-bit.

We have also one problem here https://travis-ci.org/github/JuliaData/DataFrames.jl/jobs/682985140. It is on 64 bit and happens randomly when trying to evaluate a Regex. I could not locate the bug on our side, so it might be some that got broken in Base. We from time to time get a strange error:

LoadError: LoadError: InexactError: check_top_bit(Int32, 4294967248)

Stacktrace:

 [1] top-level scope at /Users/travis/build/JuliaData/DataFrames.jl/test/runtests.jl:48
 [2] include(::String) at ./client.jl:457
 [3] top-level scope at none:6
 [4] eval(::Module, ::Any) at ./boot.jl:331
 [5] exec_options(::Base.JLOptions) at ./client.jl:272
 [6] _start() at ./client.jl:506

@Keno - maybe you can quickly diagnose what is the reason of the problem here?

@bkamins
Copy link
Member Author

bkamins commented May 4, 2020

@nalimilan, @Keno - after my update the tests pass on 1.0, 1.4 everywhere.
Also on nightly pass everywhere (Windows, Linux, both 64 and 32 bit) except OSx 64 bit where we get the same LoadError: LoadError: InexactError: check_top_bit(Int32, 4294967248) problem (so this seems to be a problem with Julia Base on OSx, but maybe we have some bug in DataFrames.jl that only manifests itself under this combination?).

@bkamins
Copy link
Member Author

bkamins commented May 4, 2020

OK - the problem with pcre on Julia nightly seems to be known so we can safely merge this PR.

@bkamins bkamins merged commit 15385f6 into JuliaData:master May 4, 2020
@bkamins bkamins deleted the julia_15_update branch May 4, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI non-breaking The proposed change is not breaking priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible test failure in upcoming Julia version 1.5
2 participants