Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkgdir instead of pathof #3289

Merged
merged 1 commit into from Mar 29, 2023
Merged

Use pkgdir instead of pathof #3289

merged 1 commit into from Mar 29, 2023

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Feb 14, 2023

This makes the examples easier to read since:

julia> joinpath(dirname(pathof(DataFrames)), "..", "docs") |> normpath
"/home/rik/.julia/packages/DataFrames/LteEl/docs"

julia> joinpath(pkgdir(DataFrames), "docs")
"/home/rik/.julia/packages/DataFrames/LteEl/docs"

Regarding availability, pkgdir is available since Julia 1.4 (https://github.com/JuliaLang/julia/blob/v1.4.0/NEWS.md) and this repo is lower bounded to Julia 1.6:

julia = "1.6"

The trailing spaces behind the tables were removed automatically by my editor. Let me know if I should undo that.

@bkamins bkamins added the doc label Feb 14, 2023
@bkamins bkamins added this to the patch milestone Feb 14, 2023
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let CI pass to make sure that all works as expected.

@bkamins
Copy link
Member

bkamins commented Feb 14, 2023

The trailing spaces behind the tables were removed automatically by my editor.

They were on purpose as in the past CI was failing without them, but maybe things have changed now and it will work without them 😄.

@bkamins bkamins closed this Mar 29, 2023
@bkamins bkamins reopened this Mar 29, 2023
@bkamins
Copy link
Member

bkamins commented Mar 29, 2023

re-triggering CI

@bkamins bkamins merged commit c72a02d into JuliaData:main Mar 29, 2023
2 checks passed
@bkamins
Copy link
Member

bkamins commented Mar 29, 2023

Thank you!

@rikhuijzer
Copy link
Contributor Author

re-triggering CI

There is also an checkbox in the settings which will give a button to update the branch based on main. Maybe you like that
image

Thank you!

Thanks!

@rikhuijzer rikhuijzer deleted the rh/pkgdir branch March 29, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants