Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nrow, ncol, and Tables.subset for eachcol and eachrow #3311

Merged
merged 1 commit into from Apr 8, 2023
Merged

add nrow, ncol, and Tables.subset for eachcol and eachrow #3311

merged 1 commit into from Apr 8, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Apr 7, 2023

Fixes #3054

@bkamins bkamins requested a review from nalimilan April 7, 2023 13:08
@bkamins bkamins added the feature label Apr 7, 2023
@bkamins bkamins added this to the 1.6 milestone Apr 7, 2023
@bkamins
Copy link
Member Author

bkamins commented Apr 7, 2023

The reason we add it is that eachcol and eachrow implement Tables.jl table interface so they should do so completely.

nalimilan
nalimilan approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of funny that ncol(eachrow(df)) works, but...

@bkamins bkamins merged commit e52b9a3 into main Apr 8, 2023
6 of 7 checks passed
@bkamins bkamins deleted the bk/tables_iterators branch April 8, 2023 11:27
@bkamins
Copy link
Member Author

bkamins commented Apr 8, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

nrow and ncol for DataFrameRows and DataFrameColumns
2 participants
@bkamins @nalimilan