Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Missings.T -> Missings.nonmissingtype #102

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Deprecate Missings.T -> Missings.nonmissingtype #102

merged 2 commits into from
Aug 30, 2019

Conversation

nickrobinson251
Copy link
Contributor

@nickrobinson251 nickrobinson251 mentioned this pull request Aug 30, 2019
Closed
rofinn
rofinn approved these changes Aug 30, 2019
View reviewed changes
src/Missings.jl
using Base: nonmissingtype
end

@deprecate T nonmissingtype false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP :(

@rofinn rofinn merged commit 108f659 into JuliaData:master Aug 30, 2019
@nickrobinson251 nickrobinson251 deleted the npr/nonmissingtype branch August 30, 2019 18:07
@nickrobinson251 nickrobinson251 mentioned this pull request Sep 1, 2019
Merged
@nalimilan
Copy link
Member

We'd better also export nonmissingtype, since in Julia 1.3 the name will be available without the Missings. prefix. See #105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

@rofinn rofinn rofinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missings.T can use Base's nonmissingtype on Julia 1.3+
4 participants
@nickrobinson251 @nalimilan @oxinabox @rofinn