Bring performance back to pre-refactor levels #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly just sprinkling around some `@inline` calls. In the `benchmarks/parsers.jl` file, I have some common types where I'm checking performance of Parsers.jl vs. Base and I also checked the current Parsers.jl release vs. #main branch. Performance looks very very close, with only Strings being about 5% slower. I ran out of gas looking to why that may be, but I think that's within the range of acceptability IMO.
Codecov ReportBase: 90.99% // Head: 91.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 90.99% 91.05% +0.05%
==========================================
Files 9 9
Lines 1611 1610 -1
==========================================
Hits 1466 1466
+ Misses 145 144 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly just sprinkling around some
@inlinecalls. In thebenchmarks/parsers.jlfile, I have some common types where I'm checking performance of Parsers.jl vs. Base and I also checked the current Parsers.jl release vs. #main branch. Performance looks very very close, with only Strings being about 5% slower. I ran out of gas looking to why that may be, but I think that's within the range of acceptability IMO.