Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring performance back to pre-refactor levels #147

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Bring performance back to pre-refactor levels #147

merged 2 commits into from
Nov 3, 2022

Commits on Nov 3, 2022

  1. Bring performance back to pre-refactor levels 

    Mainly just sprinkling around some `@inline` calls. In the
`benchmarks/parsers.jl` file, I have some common types where I'm
checking performance of Parsers.jl vs. Base and I also checked
the current Parsers.jl release vs. #main branch. Performance
looks very very close, with only Strings being about 5% slower.
I ran out of gas looking to why that may be, but I think that's
within the range of acceptability IMO.
    @quinnj
    quinnj committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    08cadbf View commit details
    Browse the repository at this point in the history

  2. fix inline callsites

    @quinnj
    quinnj committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1f3026f View commit details
    Browse the repository at this point in the history