Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Flags serializable #158

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Make Flags serializable #158

merged 1 commit into from
Jan 13, 2023

Conversation

Liozou
Copy link
Contributor

@Liozou Liozou commented Jan 9, 2023

Quick fix for JuliaData/CSV.jl#1063

This makes Flags serializable, which in turns allows serializing Options and, downstream, CSV.File and such.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Liozou!

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 87.29% // Head: 87.30% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5708204) compared to base (c033086).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   87.29%   87.30%   +0.01%     
==========================================
  Files           9        9              
  Lines        1629     1631       +2     
==========================================
+ Hits         1422     1424       +2     
  Misses        207      207              
Impacted Files Coverage Δ
src/Parsers.jl 87.00% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj quinnj merged commit f98bbce into JuliaData:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants