Introduce a specialization threshold and try to avoid generated code #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vastly improves #209. I actually thought this would trip us up sooner, but kind of forgot about it. We had some generous use of `@generated` code in a number of places, most aggregiously in `Tables.allocatecolumns` and `Tables.eachcolumn`. It simplifies the code to either just use a slow fallback, or skip the generated code entirely by using macro expansion up to a certain limit. I tried to test out a number of cases, comparing time to compile vs. resulting compiled code performance, but it can be tricky to cover a wide variety of workflows. I might try to generate a wider variety to compare benchmarks pre/post this PR.
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 95.29% 94.10% -1.19%
==========================================
Files 6 6
Lines 510 492 -18
==========================================
- Hits 486 463 -23
- Misses 24 29 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vastly improves #209. I actually thought this would trip us up sooner,
but kind of forgot about it. We had some generous use of
@generatedcode in a number of places, most aggregiously in
Tables.allocatecolumnsandTables.eachcolumn. It simplifies the codeto either just use a slow fallback, or skip the generated code entirely
by using macro expansion up to a certain limit. I tried to test out a
number of cases, comparing time to compile vs. resulting compiled code
performance, but it can be tricky to cover a wide variety of workflows.
I might try to generate a wider variety to compare benchmarks pre/post
this PR.