Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permutdims for dimension arguments #359

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

rafaqz
Copy link
Contributor

@rafaqz rafaqz commented Jan 14, 2024

Closes #328

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ee64a86) 69.74% compared to head (2a003e8) 68.47%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Cubes/Cubes.jl 71.42% 2 Missing ⚠️
src/DAT/DAT.jl 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   69.74%   68.47%   -1.27%     
==========================================
  Files          12       12              
  Lines        1702     1770      +68     
==========================================
+ Hits         1187     1212      +25     
- Misses        515      558      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7519459561

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.005%) to 69.257%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Cubes/Cubes.jl 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
src/Cubes/TransformedCubes.jl 1 80.49%
src/DAT/tablestats.jl 1 45.73%
src/Cubes/Rechunker.jl 2 88.24%
src/DAT/dciterators.jl 2 77.89%
src/Cubes/Cubes.jl 4 44.75%
src/DatasetAPI/Datasets.jl 6 76.51%
src/DAT/DAT.jl 8 72.67%
Totals Coverage Status
Change from base Build 7167813204: -0.005%
Covered Lines: 1212
Relevant Lines: 1750

💛 - Coveralls

@lazarusA
Copy link
Collaborator

@felixcremer @meggart what should we about the tests for EarthDataLab? It looks like something that should be supported?
As for the docs build I can take care of it and fix it. This PR would allow native plotting with Makie 😄 .

@meggart meggart merged commit bf31279 into JuliaDataCubes:master Jan 16, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

permute dims, dispatch correctly on DD
4 participants