-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for datetime types with timezones #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything's fine. When it will possible to implement work with the time zone without running costs it may make sense to divide the functions into 2 overloads
Alright then -- I guess we'd be ready for a new release then, unless you have anything that you'd like to get done before? Unless you have anything else, I'd like to offer you to also put your name here and, while you're editing this file anyway, bump the version to (I said that we're currently at |
Done. And thank you very much for the offer, I am pleased. One more thing
It seems to me that this will violate the conditions for auto-merging the request to the Registrator. Anyway in my of components for Dash this led to this warning:
|
That's good to know. I fixed the versions and tried to ping the registration bot, but it looks like it didn't like the repo migration and now I'll have to make a PR ... |
I didn't manage to send requests from the plotly repositories for registration via the bot, but they were sent via https://juliahub.com/ui/index.html without any problems |
Hmm, interesting, but I don't think that would have worked for changing the URL of a package that is already registered. Looking at the PRs in the General repo, a lot of other people are also changing their URLs via manual PRs. I created one just now: |
Okay, thanks. Will wait :) |
And one more thing I remembered. We should not forget to write in the documentation that we do not take into account the time zone when reading. I would prefer that you do this, because with my command of English, it may not be very clear. This doesn't cancel the release, we just need to remember to do it |
Yes, good point. Do you think putting it in the "Limitations" section in the doc is sufficient or would you want it somewhere else as well? |
Yes, I think that will be enough |
This adds support for selecting from and inserting into columns that have a timezone set. Because Julia's
DateTime
type isn't timezone aware, we simply ignore the timezone and leave handling and conversion to the user. While this is unfortunate, as previously mentioned in this issue, the TimeZones.jl library has some performance issues in its current form and just isn't a real option until this is resolved.Yes -- at least if you meant
timezone
where you wrotetimestamp
.