Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve values as doubles, not floats #44

Merged
merged 4 commits into from
May 16, 2019
Merged

Retrieve values as doubles, not floats #44

merged 4 commits into from
May 16, 2019

Conversation

aviks
Copy link
Member

@aviks aviks commented May 16, 2019

No description provided.

@aviks
Copy link
Member Author

aviks commented May 16, 2019

@quinnj Could you please take a look at the datastreams test failure on 1.x here?

@quinnj
Copy link
Member

quinnj commented May 16, 2019

Ah, so the issue is that pretty much all other packages have removed DataStreams support as its been deprecated for a while now. The error in the logs is that DataFrames dropped DataStreams support in the latest 0.18 release. So the options are to but an upper bounds on DataFrames 0.17, and tag a new release. And then switch over to Tables.jl to support the latest DataFrames release. I'm happy to take a look at switching things over here.

@ExpandingMan
Copy link
Collaborator

I had intended to add Tables.jl to this, but since JavaCall.jl is not working on default binaries until Julia 2.0 unfortunately I have no use for this package now. Should be pretty easy to change the interface to Tables.jl though.

@aviks aviks merged commit 3d540d2 into master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants