Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a driver that report indcols incorrectly #212

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

cnliao
Copy link
Contributor

@cnliao cnliao commented Oct 25, 2018

I am using an SQL Server 2008 with ODBC Driver 17 for SQL Server from Microsoft.
It seems for varchar(200) columns it sets indcols to a value larger than 201, causing
a BoundsError. Use the lessor one of elsize and indcols to work around this.

I am using an SQL Server 2008 with ODBC Driver 17 for SQL Server from Microsoft.
It seems for varchar(200) columns it sets indcols to a value larger than 201, causing
a BoundsError. Use the lessor one of elsize and indcols to work around this.
@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files           4        4           
  Lines         196      196           
=======================================
  Hits          181      181           
  Misses         15       15
Impacted Files Coverage Δ
src/Query.jl 98.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4fef6...d16773a. Read the comment docs.

@quinnj quinnj merged commit f779b91 into JuliaDatabases:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants