Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable sink #215

Closed
wants to merge 1 commit into from

Conversation

andyferris
Copy link

Is this right? Currently the sink field is ignored. At the very least this allows me to construct a TypedTables.Table.

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #215 into master will decrease coverage by 53.08%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #215       +/-   ##
===========================================
- Coverage   92.34%   39.26%   -53.09%     
===========================================
  Files           4        6        +2     
  Lines         196      461      +265     
===========================================
  Hits          181      181               
- Misses         15      280      +265
Impacted Files Coverage Δ
src/Query.jl 50.75% <25%> (-47.31%) ⬇️
src/types.jl 40% <0%> (-60%) ⬇️
src/API.jl 31.66% <0%> (-58.81%) ⬇️
src/ODBC.jl 45.94% <0%> (-36.32%) ⬇️
src/Sink.jl 0% <0%> (ø)
src/sqlreplmode.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c614991...7e4cd81. Read the comment docs.

@quinnj
Copy link
Member

quinnj commented May 23, 2020

Implemented in #263

@quinnj quinnj closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants