Big rewrite of package #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the big changes include: * This will be a breaking, 1.0 release * Use of BinaryBuilder for source driver managers * Streamlines resultset fetching process supporting super-efficient direct column fetching for native types * More robust/useful statement preparation and parameter binding by conforming to the `DBInterface` interface * Moving the package to own it's own config; the aim here is to cut down on all the crazy config stuff available across the various driver managers and attempt to keep it close and sane; additional methods for adding/getting/deleting drivers and datasources have been added * Enhance debugging capabilities via `ODBC.setdebug` and passing `debug=true` when executing statements. Things still to do: * test new driver/dsn management methods * ensure tests pass across all platforms * little more parameter binding testing * Update index.md docs (internal docs have been updated)
giordano
reviewed
May 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 72.67% 72.67%
=======================================
Files 5 5
Lines 644 644
=======================================
Hits 468 468
Misses 176 176 Continue to review full report at Codecov.
|
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
This was referenced May 23, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the big changes include:
direct column fetching for native types
conforming to the
DBInterfaceinterfacedown on all the crazy config stuff available across the various driver
managers and attempt to keep it close and sane; additional methods for
adding/getting/deleting drivers and datasources have been added
ODBC.setdebugand passingdebug=truewhen executing statements.Things still to do: