Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use non-differentiation on any constructors #258

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

ChrisRackauckas
Copy link
Member

I don't really know what to call this, but it fixes #257 , whatever that is.

I don't really know what to call this, but it fixes #257 , whatever that is.
since if you accidentally hit this it must be doing the same thing just on ranges.
@oxinabox oxinabox changed the title Fix non-differentiation ruleset for keyword argument dropping Don't use non-differentiation on any constructors Sep 3, 2020
@oxinabox
Copy link
Member

oxinabox commented Sep 3, 2020

Merged and tag when ever you are ready.
You have merge rights on JuliaDiff IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Non-Diff Rules can cause Zygote to change keyword arguments
3 participants