Pin the Integration Test for Zygote to Julia 1.4 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
previously approved these changes
Sep 3, 2020
|
This is failing. |
|
will need rebasing once #258 is merged |
oxinabox
force-pushed
the
ox/integrationtest14
branch
from
54655c0
to
284e5eb
Compare
|
@willtebbutt can you approve so i can merge |
willtebbutt
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Zygote's tests are broken in Juliia 1.5 (FluxML/Zygote.jl#775)
we haven't had integration tests usable.
and #257 happened.
Our downstream Integration tests would have caught that.
cc @ChrisRackauckas