Add Array * Scalar #268
Merged
Add Array * Scalar #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgubic
approved these changes
Sep 17, 2020
| B = randn(n, p) | ||
| Ȳ = randn(m, p) | ||
| rrule_test(*, Ȳ, (A, randn(m, n)), (B, randn(n, p))) | ||
| @testset "Matrix-Matrix" begin |
There was a problem hiding this comment.
Out of scope perhaps but are there tests for Vector*Matrix anywhere? dot is tested but I don't think * is
There was a problem hiding this comment.
I am not sure we actually have a matric vector multiply rrule defined.
There was a problem hiding this comment.
cool I would be keen to tackle this
oxinabox
commented
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nabla has this, we should have it too.
I am sure it can be extended to work for complex but i don't know how so am happy to make it a follow up PR