Reformat rrule_test for more informative output on failure #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the check for all rules comparing approximately equal to their finite differencing counterparts fails, the test failure just tells you that `all(...)` was `false`. If we restructure it as a loop over the results, a failure will display the actual values that were compared, which is much more informative. While I was in here, I also changed the `map` directly below to a loop, since that's what the `map` was doing; the resulting vector of `nothing`s was not being used. It could just have well have been a `foreach`, but an explicit loop seems clearer.
|
I'm just going to merge this since it's a pretty small change without any real downside, and it will be useful for debugging the test failures in #29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the check for all rules comparing approximately equal to their finite differencing counterparts fails, the test failure just tells you that
all(...)wasfalse. If we restructure it as a loopover the results, a failure will display the actual values that were compared, which is much more informative.
While I was in here, I also changed the
mapdirectly below to a loop, since that's what themapwas doing; the resulting vector ofnothings was not being used. It could just have well have been aforeach, but an explicit loop seems clearer.I ran into this because, as it turns out, I'm real good at getting tests to fail when adding new stuff.