Add scalar-array / and \ #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
reviewed
Sep 29, 2020
| ##### | ||
| ##### `\`, `/` matrix-scalar_rule | ||
|
|
||
| function rrule(::typeof(/), A::AbstractArray{<:Real}, b::Real) |
There was a problem hiding this comment.
Are these maybe a bit too abstractly typed?
There was a problem hiding this comment.
I don' t think so in this case.
But I also don't think this is the PR to be having the discussion about it in.
This matchs to * defined above.
I think changing * and changing this can happen at same time
willtebbutt
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for invenia/Nabla.jl#189
I worked this one out with a white-board.
I'm not good at math though, but tests pass.
So I guess i got it right