use add!! and rename _mulsubtrans!! #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
Oct 6, 2020
| Ā = _add!(Ā, U * _add!(S * FVᵀV̄ * Vt, (S \ V̄') * ImVVᵀ)) | ||
| Ā = add!!(U * FUᵀŪ * S, ImUUᵀ * (Ū / S)) * Vt | ||
| Ā = add!!(Ā, U * S̄ * Vt) | ||
| Ā = add!!(Ā, U * add!!(S * FVᵀV̄ * Vt, (S \ V̄') * ImVVᵀ)) |
There was a problem hiding this comment.
i don't love that add!! is exported from ChainRulesCore (missed that in the PR that added it)
There was a problem hiding this comment.
Why?
It is part of the public API.
The whole public API is exported.
Except for debug_mode
oxinabox
requested review from
nickrobinson251
and removed request for
mattBrzezinski
mattBrzezinski
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to JuliaDiff/ChainRulesCore.jl#226
Needs that to be merged first