Bring in BLAS names that are used without qualification #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just do a full import, and then qualify the clash? |
|
If I remember correctly, I hadn't done that before because a warning is emitted, but I might not be remembering correctly. I'll give that a go. |
Currently some of the rules are calling `blascopy!` and `scal!` without qualification, which fails, since we haven't done a full `using` for the BLAS submodule. This adds a `using` and an `import` for `dot` on earlier versions of Julia to avoid a name conflict between LinearAlgebra and BLAS which has since been fixed.
|
Implemented that. Thanks Lyndon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the rules are calling
blascopy!andscal!without qualification, which fails, since we haven't done a fullusingfor the BLAS submodule. (We can do that later, but currently there's an exportconflict with LinearAlgebra itself.) So for now we can just selectively use the names.