Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in BLAS names that are used without qualification #61

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Bring in BLAS names that are used without qualification #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/ChainRules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@ module ChainRules

using Cassette
using LinearAlgebra
using LinearAlgebra.BLAS
using Base.Broadcast: materialize, materialize!, broadcasted, Broadcasted, broadcastable

import NaNMath, SpecialFunctions, LinearAlgebra, LinearAlgebra.BLAS
if VERSION < v"1.3.0-DEV.142"
# In prior versions, the BLAS submodule also exported `dot`, which caused a conflict
# with its parent module. To get around this, we can simply create a hard binding for
# the one we want to use without qualification.
import LinearAlgebra: dot
end

import NaNMath, SpecialFunctions

export AbstractRule, Rule, frule, rrule

Expand Down
1 change: 0 additions & 1 deletion src/rules/linalg/blas.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ package (https://github.com/invenia/DiffLinearAlgebra.jl).
=#

using LinearAlgebra: BlasFloat
using LinearAlgebra.BLAS: gemm

_zeros(x) = fill!(similar(x), zero(eltype(x)))

Expand Down