Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize gradient in HessianResult to avoid undef errors when #9

Merged
merged 1 commit into from Dec 3, 2019
Merged

Initialize gradient in HessianResult to avoid undef errors when #9

merged 1 commit into from Dec 3, 2019

Conversation

andreasnoack
Copy link
Member

using BigFloats in Hessian computations

Fixes #8

I wanted to add a test but that would require ForwardDiff, i.e. something like

# hessian! + BigFloat #
# -----------------------------#

xb = big.(ones(2))
rb = HessianResult(xb)
ForwardDiff.hessian!(rb, sqrt(prod(x)), xb)
@test hessian(rb) == big.([-1 1; 1 -1]/4)

Would you like the test added to ForwardDiff?

using BigFloats in Hessian computations

Fixes #8
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.302% when pulling e4ed5ab on andreasnoack:an/big into 8d12336 on JuliaDiff:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.302% when pulling e4ed5ab on andreasnoack:an/big into 8d12336 on JuliaDiff:master.

@chriscoey
Copy link

bump

@chriscoey
Copy link

@andreasnoack do you have the ability to merge?

@andreasnoack andreasnoack merged commit a6bd31b into JuliaDiff:master Dec 3, 2019
@andreasnoack andreasnoack deleted the an/big branch December 3, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined reference when computing Hessian with BigFloats
3 participants