Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2-arg atan #91

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Implement 2-arg atan #91

merged 7 commits into from
Mar 23, 2022

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Mar 5, 2022

This PR implements 2-argument atan:

  • atan(::Dual, ::Dual)
  • atan(::Dual, ::Real)
  • atan(::Real, ::Dual)

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #91 (e303e15) into master (1036d45) will increase coverage by 2.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   46.03%   48.34%   +2.30%     
==========================================
  Files           1        1              
  Lines         202      211       +9     
==========================================
+ Hits           93      102       +9     
  Misses        109      109              
Impacted Files Coverage Δ
src/dual.jl 48.34% <100.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1036d45...e303e15. Read the comment docs.

@sethaxen
Copy link
Member Author

@dlfivefifty can you review this PR?

@dlfivefifty dlfivefifty merged commit b54f132 into master Mar 23, 2022
@dlfivefifty dlfivefifty deleted the atan branch March 23, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants