-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Callable struct #144
Conversation
Test passed.. So I think my local failed test is due to Julia 1.5 |
The test failure on Julia 1.5 looks identical with the tagged version of this package. Needs fixing but it's an orthogonal concern to this PR.
|
The only problem I have with this PR is that it will probably give an error when the closure has a tracked field. Can you please add a test case like that? |
Hmm I don't think there is currently a correct way to implement this generically. However, we already have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments above.
Sorry for my delay, I'm meeting a deadline last week. @mohamed82008 , I don't know the exact meaning of "closure has a tracked field", do you mean that a struct field is tracked? |
Close to encourage better solutions. |
Fix #135
Though master branch (without this PR) local unit test will fail at
This PR doesn't try to solve this problem, so CI will fail I guess. But my local unit test at least failed at same location as master branch while added unit test
CallableStructTests.jl
will pass: