Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend develop instead of add. #844

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Recommend develop instead of add. #844

merged 1 commit into from
Sep 24, 2018

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Sep 24, 2018

@KristofferC pointed out that this is better since add does a (full ?) clone of the package, but we already have that clone so we can just point to it with develop.

@mortenpi mortenpi merged commit 6c086d9 into master Sep 24, 2018
@mortenpi mortenpi deleted the fe/dev branch September 24, 2018 21:46
@mortenpi
Copy link
Member

It also feels more correct actually -- a package checked out on Travis is more "dev" rather than "released" (add somewhat implies the latter, to me at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants