Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing double prefixes bug in produce_or_load #393

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

pjgorski
Copy link
Contributor

See #392

I also created a test, but I was unable to test it locally. Each time I ran tests BSON package was uninstalled, and the lack of this package produced errors, and further tests were unable to be run. The issue might be with the system not making a distinction between a system package and a local one.

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. I think the test can be set up better.

test/savefiles_tests.jl Outdated Show resolved Hide resolved
@pjgorski pjgorski requested a review from Datseris July 2, 2023 22:56
@pjgorski
Copy link
Contributor Author

pjgorski commented Jul 3, 2023

I managed to run and pass the tests locally.

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will merge as soon as tests pass!

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #393 (a5051ed) into main (ab87902) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   90.69%   90.57%   -0.13%     
==========================================
  Files           8        8              
  Lines         752      753       +1     
==========================================
  Hits          682      682              
- Misses         70       71       +1     
Impacted Files Coverage Δ
src/saving_files.jl 91.66% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Datseris Datseris merged commit 506109c into JuliaDynamics:main Jul 3, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants