Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Makie to 0.18, (keep existing compat) #113

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Makie package from 0.17 to 0.17, 0.18.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@Datseris Datseris merged commit 55863fa into main Oct 12, 2022
@Datseris Datseris deleted the compathelper/new_version/2022-10-12-16-52-46-052-00142853705 branch October 12, 2022 19:14
@Datseris
Copy link
Member

cc @fbanning , this Makie release had the bullet point:

Breaking Refactored DataInspector to use tooltip. This results in changes in the attributes of DataInspector. Added inspector_label, inspector_hover and inspector_clear as optional attributes MakieOrg/Makie.jl#2095.

(from https://github.com/MakieOrg/Makie.jl/blob/master/NEWS.md )

I am not sure if this broke, or unbroke, some behavior of the tooltip usage in the agent app. (I've merged this because this is a good release of Makie, with many new good features and performance improvements)

@fbanning
Copy link
Member

Cool, nice to see some changes to DataInspector, it worked just fine before but was a bit hard to understand which attribute does what and that seems to have been tackled by the PR.

Did you test a simple inspection with our plot? Did you experience any problems? I've had a quick look through the list of changes and most of those attributes I didn't use in our relatively simple inspector function. If you didn't test anything at all, I'll try that.

@Datseris
Copy link
Member

I didn't test something, but I also saw the changes and thought "Oh well, we probably didn't use that so it's probably okay"... :'D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants