This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Fix inspection for Makie 0.18 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbanning
added
bug
|
Ah nevermind, You OK with this, @Datseris ? |
|
Did you publish a new tag of InteractiveDynamics with this in? (patch number should have been incremented here, as no |
|
No I didn't because I merged it into the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with
DataInspectorfrom #113 which raised Makie compat tov0.18. This PR should cover all changes made toDataInspector. It now looks a lot nicer as well. :)NB: This PR builds on top of the changes made in #114 and currently it's necessary to
]add OSMMakie#masterto test this PR. It can only be merged onceOSMMakie v0.0.6is available on the public registry (it's registered and will be auto-merged with the next batch). To indicate this, I will leave this as a draft PR and only convert it to ready once the registry is updated.