Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polishing CI and tests #62

Merged
merged 1 commit into from
May 9, 2023
Merged

polishing CI and tests #62

merged 1 commit into from
May 9, 2023

Conversation

Krastanov
Copy link
Member

@Krastanov Krastanov commented May 7, 2023

This PR updates the CI, sets automatic updates for the CI and compat sections, adds static analysis tests, and restructures the tests to follow the SciML conventions (using SafeTestsets).

Edit: It also does doctests now and it tests back to 1.2, as well as some win/mac combinations.

Edit2: The type-dispatch tests were broken on 32bit architectures. That is fixed too now.

@Krastanov Krastanov force-pushed the polish branch 2 times, most recently from e1363bc to 144d61c Compare May 8, 2023 00:20
@Krastanov
Copy link
Member Author

I will wait for a day or two and then merge this even without review. It contains only logistical fixes/updates/reorganization. Anyone, let me know if you would prefer that I wait on the merge.

@gerlero
Copy link
Member

gerlero commented May 9, 2023

@Krastanov looks good!

I'm ignoring the AppVeyor failures since I assume those need to be fixed independently by @BenLauwens.

Incidentally, the README needs a small correction here:

https://github.com/BenLauwens/ResumableFunctions.jl/blob/e7fd5f0cb541911f2519133101232cce74fa1a1c/README.md?plain=1#L114

That should be changed to v0.6.1 v0.6.2, to match the version set in the Project.toml here, which has to be a patch release with the fix for #60. Maybe you can also make that change in this PR?

Besides that and as far as I'm concerned, LGTM and registered soon.

EDIT: v0.6.1 -> v0.6.2

@gerlero gerlero mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants