Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sparse matrix issue. #16

Merged
merged 3 commits into from
Aug 15, 2017
Merged

Fix sparse matrix issue. #16

merged 3 commits into from
Aug 15, 2017

Conversation

maikkirapo
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 96.154% when pulling 5d7a0fb on Sparse_matrix_fix into b7bc187 on master.

ahojukka5
ahojukka5 reviewed Aug 14, 2017
View reviewed changes
src/craig_bampton.jl Outdated
w2 = eigvals(Kll,Mll)
X1 = eigvecs(Kll,Mll)
if issparse(K) && issparse(M)
w2 = eigs(Kll,Mll)[1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, use either

w2, X1 = eigs(Kll, Mll)

or

tmp = eigs(Kll, Mll)
w2 = tmp[1]
X1 = tmp[2]

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.7%) to 94.34% when pulling 32cf832 on Sparse_matrix_fix into b7bc187 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 98.039% when pulling 090f649 on Sparse_matrix_fix into b7bc187 on master.

@ahojukka5
Copy link
Member

Do you want to squash before merging?

@maikkirapo
Copy link
Contributor Author

No.

@ahojukka5 ahojukka5 merged commit 15b909d into master Aug 15, 2017
@ahojukka5 ahojukka5 deleted the Sparse_matrix_fix branch August 15, 2017 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojukka5 ahojukka5 ahojukka5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maikkirapo @coveralls @ahojukka5