Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume preserving feedforward neural network (vpffnn) #128

Merged
merged 21 commits into from
Apr 10, 2024

Conversation

benedict-96
Copy link
Collaborator

Added volume-preserving feedforward neural network (vpffnn). The corresponding layers essentially perform:

$$\psi: x \mapsto \sigma(Lx + b),$$

where $L$ is a lower-triangular layer (the corresponding version for the upper triangular layer also exists). By construction $\mathrm{det}(\nabla\psi) = 1$ and the layer is therefore volume-preserving. What will be used in the end is the neural network architecture VolumePreservingFeedForward.

A big part of this pr are docs and various tikz pictures explaining the constructions made here. There are also tests.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 62.28814% with 178 lines in your changes are missing coverage. Please review.

Project coverage is 62.53%. Comparing base (908bc21) to head (c2d7eb6).

Files Patch % Lines
src/arrays/triangular.jl 18.57% 57 Missing ⚠️
src/architectures/volume_preserving_feedforward.jl 2.85% 34 Missing ⚠️
src/kernels/kernel_ad_routines/mat_tensor_mul.jl 78.70% 33 Missing ⚠️
src/architectures/neural_network_integrator.jl 0.00% 26 Missing ⚠️
src/kernels/mat_tensor_mul.jl 90.00% 8 Missing ⚠️
src/arrays/lower_triangular.jl 78.12% 7 Missing ⚠️
src/arrays/upper_triangular.jl 80.55% 7 Missing ⚠️
src/layers/volume_preserving_feedforward.jl 84.21% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   62.58%   62.53%   -0.05%     
==========================================
  Files         105      111       +6     
  Lines        2750     3222     +472     
==========================================
+ Hits         1721     2015     +294     
- Misses       1029     1207     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft April 9, 2024 07:21
@benedict-96 benedict-96 marked this pull request as ready for review April 9, 2024 08:06
@michakraus michakraus merged commit af93bf5 into main Apr 10, 2024
11 of 16 checks passed
@michakraus michakraus deleted the volume_preserving_feedforward branch April 10, 2024 15:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants