Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cu() behavior for complex floating point numbers #91

Closed
btmit opened this issue Apr 3, 2020 · 1 comment · Fixed by #489
Closed

cu() behavior for complex floating point numbers #91

btmit opened this issue Apr 3, 2020 · 1 comment · Fixed by #489
Labels
cuda array Stuff about CuArray. enhancement New feature or request good first issue Good for newcomers

Comments

@btmit
Copy link

btmit commented Apr 3, 2020

cu() is opinionated and automatically converts Float64 to Float32 on the GPU.

It seems like it would make sense for it also to convert ComplexF64 to ComplexF32.

Could we consider adding this behavior?
@maleadt
Copy link
Member

maleadt commented Apr 4, 2020

Yes, that makes sense to me.

@maleadt maleadt transferred this issue from JuliaGPU/CuArrays.jl May 27, 2020
@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request good first issue Good for newcomers labels May 27, 2020
@pabloferz pabloferz mentioned this issue Oct 13, 2020
Merged
bors bot added a commit that referenced this issue Oct 14, 2020
@bors @pabloferz
Merge #489
be0d0a8 
489: Convert AbstractArray{ComplexF64} to CuArray{ComplexF32} by default r=maleadt a=pabloferz

Fixes #91

Co-authored-by: Pablo Zubieta <8410335+pabloferz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cuda array Stuff about CuArray. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert AbstractArray{ComplexF64} to CuArray{ComplexF32} by default pabloferz/CUDA.jl
2 participants
@maleadt @btmit